Skip to content

imuIdSystem, imRtdProvider: update endpoint and cookie lifetime - #26

Closed
kunaisn wants to merge 2 commits into
masterfrom
agent/imuid-update-endpoint-to-ups
Closed

kunaisn wants to merge 2 commits into
masterfrom
agent/imuid-update-endpoint-to-ups

Conversation

@kunaisn

@kunaisn kunaisn commented Nov 4, 2026 •

Copy link
Copy Markdown

Type of change

  • Bugfix
  • Refactoring (no functional changes, no api changes)

Description of change

  • imuIdSystem のデフォルトの API ドメインを sync6.im-apps.net から ups.im-apps.net に変更します。
  • imuIdSystem と imRtdProvider で、_im_vid cookie の有効期限を37か月から400日に変更します。
  • 新規の訪問者に _im_vid cookie が保存されていなかった問題を修正します。

Other information

  • npx gulp test-only --file test/spec/modules/imuIdSystem_spec.js:21件成功
  • npx gulp test-only --file test/spec/modules/imRtdProvider_spec.js:22件成功
  • npx gulp lint --nolintfix --files modules/imuIdSystem.js,modules/imRtdProvider.js,test/spec/modules/imuIdSystem_spec.js:成功

🤖 Generated with Claude Code

@kunaisn

kunaisn commented Nov 4, 2026

Copy link
Copy Markdown
Author

The actions actions/checkout@v7 ... are not allowed in IntimateMerger/Prebid.js because all actions must be pinned to a full-length commit SHA.

prebidがactionsのsha hashを固定してないので、即座に失敗してるらしいです

@kunaisn

kunaisn commented Nov 4, 2026 •

Copy link
Copy Markdown
Author

本家に出す時に、ざっくり考えたPR文です

タイトル: imuIdSystem: update API endpoint to ups.im-apps.net

Type of change

  • Refactoring

Description of change

Updates the default API domain of imuIdSystem from sync6.im-apps.net to ups.im-apps.net. Request parameters and the response schema remain compatible, and params.url handling is unchanged.

  • modules/imuIdSystem.js: apiDomain constant.
  • test/spec/modules/imuIdSystem_spec.js: the URL pattern asserted for the default endpoint.

When a request has no vid, the new endpoint generates one and returns it, so the module now stores the existing _im_vid cookie for visitors who do not have it yet. No module code change is needed for this.

Other information

  • npx gulp test-only --file test/spec/modules/imuIdSystem_spec.js: 21 tests pass.
  • npx gulp lint --nolintfix --files modules/imuIdSystem.js,test/spec/modules/imuIdSystem_spec.js: passes.

🤖 Generated with Claude Code

@eknis

eknis commented Nov 6, 2026

Copy link
Copy Markdown
Member

よく変わるんでわかってないですが
Type of changeってどんな選択肢に今なってますかね?
maintenanceみたいなのあったらそれがいいかも

@kunaisn

kunaisn commented Nov 6, 2026 •

Copy link
Copy Markdown
Author

@eknis
こちらの話ですよね。。。

https://github.com/prebid/Prebid.js/blob/16597b34e5d4e5b540f7450fe7b2990a7851dcb3/.github/PULL_REQUEST_TEMPLATE.md

ぱっと見なさそうですが、ラベルにはあるみたいなので、Otherのまま、ラベルの方を追加する感じが良いでしょうか?
(強いて言えばRefactoringでしょうか、、、)

https://github.com/prebid/Prebid.js/pull/15835

@eknis

eknis commented Nov 6, 2026

Copy link
Copy Markdown
Member

微妙ですねえ~
でもRefactoringでいいんじゃないでしょうか!
Otherと言われると色々考えちゃうんでそんなreview厳しくないですがわかりやすいほうがいいかなと!

@kunaisn

kunaisn commented Nov 6, 2026 •

Copy link
Copy Markdown
Author

↑上のやつをEditして、Type of changeを変えてみました!

この辺りの文脈わからないので、ニュアンスを教えていただいて助かります!

@eknis eknis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kunaisn

kunaisn commented Nov 11, 2026 •

Copy link
Copy Markdown
Author

PR概要文最終案

タイトル: imuIdSystem: update API endpoint to ups.im-apps.net

## Type of change
- [x] Refactoring (no functional changes, no api changes)

## Description of change
Updates the default API domain of `imuIdSystem` from `sync6.im-apps.net` to `ups.im-apps.net`. Request parameters and the response schema remain compatible, and `params.url` handling is unchanged.

- `modules/imuIdSystem.js`: `apiDomain` constant.
- `test/spec/modules/imuIdSystem_spec.js`: the URL pattern asserted for the default endpoint.

When a request has no `vid`, the new endpoint generates one and returns it, so the module now stores the existing `_im_vid` cookie for visitors who do not have it yet. No module code change is needed for this.

## Other information
- `npx gulp test-only --file test/spec/modules/imuIdSystem_spec.js`: 21 tests pass.
- `npx gulp test-only`: 27668 tests pass, 0 fail, 7 skipped.
- `npx gulp lint --nolintfix --files modules/imuIdSystem.js,test/spec/modules/imuIdSystem_spec.js`: passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

@kunaisn kunaisn changed the title imuIdSystem: update API endpoint to ups.im-apps.net imuIdSystem, imRtdProvider: update endpoint and cookie lifetime Nov 11, 2026
@kunaisn

kunaisn commented Nov 11, 2026 •

Copy link
Copy Markdown
Author

@eknis @hamawata @fecker

クッキーの有効期限を400日に変更する修正を入れたので、確認お願いします!

PRは以下を予定してます。

  • タイトル: imuIdSystem, imRtdProvider: update endpoint and cookie lifetime
## Type of change
- [x] Bugfix
- [x] Refactoring (no functional changes, no api changes)

## Description of change
- Updates the default API domain of `imuIdSystem` from `sync6.im-apps.net` to `ups.im-apps.net`.
- Changes the `_im_vid` cookie lifetime in `imuIdSystem` and `imRtdProvider` from 37 months to 400 days.
- Fixes an issue where the `_im_vid` cookie was not set for new visitors.

## Other information
- `npx gulp test-only --file test/spec/modules/imuIdSystem_spec.js`: 21 tests pass.
- `npx gulp test-only --file test/spec/modules/imRtdProvider_spec.js`: 22 tests pass.
- `npx gulp lint --nolintfix --files modules/imuIdSystem.js,modules/imRtdProvider.js,test/spec/modules/imuIdSystem_spec.js`: passes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

(11月11日20時36分編集)

@kunaisn
kunaisn requested a review from eknis November 11, 2026 09:45
kunaisn and others added 2 commits November 11, 2026 18:47
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both modules write the same _im_vid cookie with a 37-month expiry.
Chrome caps cookie lifetimes at 400 days, so use that value in both.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kunaisn
kunaisn force-pushed the agent/imuid-update-endpoint-to-ups branch from 6e965d0 to 3edf603 Compare November 11, 2026 09:48

@hamawata hamawata left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fecker fecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunaisn

kunaisn commented Nov 12, 2026

Copy link
Copy Markdown
Author

本家でマージ済みのためクローズします!
prebid#16154

@kunaisn kunaisn closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants